Issue 290993007: Cross-platform cleanup in preparation of better ARM code for indexed load/store.

Issue 290993007: Cross-platform cleanup in preparation of better ARM code for indexed load/store. (Closed)

Created:
6 years, 7 months ago by regis

Modified:
6 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cross-platform cleanup in preparation of better ARM code for indexed load/store. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36459

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -51 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		1 chunk	+6 lines, -10 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

This is a follow up of my last cl. Since these FlowGraphCompiler methods will generate ...

6 years, 7 months ago (2014-05-21 22:56:07 UTC) #1

srdjan

lgtm https://codereview.chromium.org/290993007/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://codereview.chromium.org/290993007/diff/1/runtime/vm/intermediate_language_x64.cc#newcode1155 runtime/vm/intermediate_language_x64.cc:1155: : compiler->FlowGraphCompiler::ElementAddressForIntIndex( Remove FlowGraphCompiler::

6 years, 7 months ago (2014-05-21 23:12:29 UTC) #2

regis

Thanks! https://codereview.chromium.org/290993007/diff/1/runtime/vm/intermediate_language_x64.cc File runtime/vm/intermediate_language_x64.cc (right): https://codereview.chromium.org/290993007/diff/1/runtime/vm/intermediate_language_x64.cc#newcode1155 runtime/vm/intermediate_language_x64.cc:1155: : compiler->FlowGraphCompiler::ElementAddressForIntIndex( On 2014/05/21 23:12:29, srdjan wrote: > ...

6 years, 7 months ago (2014-05-21 23:18:14 UTC) #3

regis

6 years, 7 months ago (2014-05-21 23:20:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36459 (presubmit successful).

Expand Messages | Collapse Messages