Issue 290993003: VM: Remove unnecessary field use_kind from IL instructions.

Issue 290993003: VM: Remove unnecessary field use_kind from IL instructions. (Closed)

Created:
6 years, 7 months ago by Florian Schneider

Modified:
6 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Remove unnecessary field use_kind from IL instructions. We already store a SSA- or temp-index that indicates if a definition is used or not. There is no need to have a separate field to store this information. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36432

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -100 lines)			Patch
M	runtime/vm/flow_graph.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	48 chunks	+55 lines, -55 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	5 chunks	+1 line, -7 lines	2 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/290993003/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/290993003/diff/1/runtime/vm/intermediate_language.h#newcode1778 runtime/vm/intermediate_language.h:1778: bool HasSSATemp() const { return ssa_temp_index_ >= 0; ...

6 years, 7 months ago (2014-05-20 16:03:48 UTC) #2

Florian Schneider

https://codereview.chromium.org/290993003/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/290993003/diff/1/runtime/vm/intermediate_language.h#newcode1778 runtime/vm/intermediate_language.h:1778: bool HasSSATemp() const { return ssa_temp_index_ >= 0; } ...

6 years, 7 months ago (2014-05-21 14:03:44 UTC) #3

Florian Schneider

6 years, 7 months ago (2014-05-21 14:26:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36432 (presubmit successful).

Expand Messages | Collapse Messages