Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 290393003: Remove isolate_throws_test. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove isolate_throws_test. It assumes that an exception in an isolate terminates the program. That is not the case, so it has status-file exceptions on all platforms. May be related to http://dartbug.com/12587 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=36291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M tests/isolate/isolate.status View 3 chunks +0 lines, -3 lines 0 comments Download
D tests/isolate/isolate_throws_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-19 11:48:40 UTC) #1
kustermann
lgtm
6 years, 7 months ago (2014-05-19 11:52:15 UTC) #2
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-19 11:52:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36291 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698