Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 29013005: Report compile-time error for const factories redirecting to malformed type (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Report compile-time error for const factories redirecting to malformed type (fix issue 14305). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
runtime/vm/class_finalizer.cc View 1 chunk +7 lines, -1 line 0 comments Download
tests/language/language.status View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 2 months ago (2013-10-23 20:54:16 UTC) #1
Ivan Posva
LGTM -ip
7 years, 2 months ago (2013-10-23 21:00:43 UTC) #2
regis
7 years, 2 months ago (2013-10-23 21:03:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698