Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 290073002: Use deferred loading for message catalogs. (Closed)

Created:
6 years, 7 months ago by Alan Knight
Modified:
6 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use deferred loading for message catalogs. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=36235

Patch Set 1 #

Total comments: 4

Patch Set 2 : Make the generated deferredLibraries variable private #

Patch Set 3 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -26 lines) Patch
M pkg/intl/lib/generate_localized.dart View 1 2 chunks +10 lines, -19 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/test/message_extraction/message_extraction_test.dart View 1 2 4 chunks +22 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
Also contains code to add a --local option to the message_extraction_test, so you can generate ...
6 years, 7 months ago (2014-05-15 19:18:17 UTC) #1
Emily Fortuna
lgtm, minor nits https://codereview.chromium.org/290073002/diff/1/pkg/intl/lib/generate_localized.dart File pkg/intl/lib/generate_localized.dart (right): https://codereview.chromium.org/290073002/diff/1/pkg/intl/lib/generate_localized.dart#newcode187 pkg/intl/lib/generate_localized.dart:187: output.write(" '$locale' : () => ${_libraryName(locale)}.loadLibrary(),\n"); ...
6 years, 7 months ago (2014-05-15 19:24:36 UTC) #2
Alan Knight
Committed patchset #3 manually as r36235 (presubmit successful).
6 years, 7 months ago (2014-05-15 20:02:10 UTC) #3
Alan Knight
6 years, 7 months ago (2014-05-15 20:02:18 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/290073002/diff/1/pkg/intl/lib/generate_locali...
File pkg/intl/lib/generate_localized.dart (right):

https://codereview.chromium.org/290073002/diff/1/pkg/intl/lib/generate_locali...
pkg/intl/lib/generate_localized.dart:187: output.write("  '$locale' : () =>
${_libraryName(locale)}.loadLibrary(),\n");
On 2014/05/15 19:24:36, Emily Fortuna wrote:
> 80 char

Done.

https://codereview.chromium.org/290073002/diff/1/pkg/intl/test/message_extrac...
File pkg/intl/test/message_extraction/message_extraction_test.dart (right):

https://codereview.chromium.org/290073002/diff/1/pkg/intl/test/message_extrac...
pkg/intl/test/message_extraction/message_extraction_test.dart:19: String get
tempDir => _tempDir == null ? _tempDir = _createTempDir() : _tempDir;
On 2014/05/15 19:24:36, Emily Fortuna wrote:
> can you put a brief comment above this section here similar to the lines 49-51
> explaining what these functions are?

Done.

Powered by Google App Engine
This is Rietveld 408576698