Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 289983003: Remove the dependency of tools/bot/bot_utils.py on tools/utils.py (Closed)

Created:
6 years, 7 months ago by Bill Hesse
Modified:
6 years, 7 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Remove the dependency of tools/bot/bot_utils.py on tools/utils.py This is needed so that the multivm builder can use bot_utils.py without checking out tools/gyp, which breaks the multivm build. BUG= TBR=ricow Committed: https://code.google.com/p/dart/source/detail?r=36296

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restore GetUtils function, which is called by other files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M tools/bots/bot_utils.py View 1 4 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
6 years, 7 months ago (2014-05-15 12:10:27 UTC) #1
ricow1
https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py File tools/bots/bot_utils.py (left): https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py#oldcode21 tools/bots/bot_utils.py:21: utils = GetUtils() you can't do this, this is ...
6 years, 7 months ago (2014-05-15 13:28:38 UTC) #2
Bill Hesse
https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py File tools/bots/bot_utils.py (left): https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py#oldcode21 tools/bots/bot_utils.py:21: utils = GetUtils() On 2014/05/15 13:28:38, ricow1 wrote: > ...
6 years, 7 months ago (2014-05-15 13:57:03 UTC) #3
Bill Hesse
On 2014/05/15 13:57:03, Bill Hesse wrote: > https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py > File tools/bots/bot_utils.py (left): > > https://codereview.chromium.org/289983003/diff/1/tools/bots/bot_utils.py#oldcode21 ...
6 years, 7 months ago (2014-05-15 14:55:59 UTC) #4
Bill Hesse
6 years, 7 months ago (2014-05-19 13:43:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698