Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 289803004: Canonicalize dart:_blink resolver names (Closed)

Created:
6 years, 7 months ago by Leaf
Modified:
6 years, 7 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Canonicalize dart:_blink resolver names BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=36196

Patch Set 1 #

Patch Set 2 : Generate new SDK #

Total comments: 2

Patch Set 3 : Regenerate SDK after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -176 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 69 chunks +172 lines, -172 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 5 chunks +21 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Leaf
This is the dart half of the changes to canonicalize the native resolver strings. It ...
6 years, 7 months ago (2014-05-14 21:18:22 UTC) #1
Jacob
https://codereview.chromium.org/289803004/diff/20001/sdk/lib/_blink/dartium/_blink_dartium.dart File sdk/lib/_blink/dartium/_blink_dartium.dart (right): https://codereview.chromium.org/289803004/diff/20001/sdk/lib/_blink/dartium/_blink_dartium.dart#newcode977 sdk/lib/_blink/dartium/_blink_dartium.dart:977: Native_CanvasRenderingContext2D__fill_1_Callback(mthis, winding) native "CanvasRenderingContext2D_fill_Callback_1_CanvasWindingRule"; CanvasWindingRule is an enum. I ...
6 years, 7 months ago (2014-05-14 21:34:36 UTC) #2
Leaf
https://codereview.chromium.org/289803004/diff/20001/sdk/lib/_blink/dartium/_blink_dartium.dart File sdk/lib/_blink/dartium/_blink_dartium.dart (right): https://codereview.chromium.org/289803004/diff/20001/sdk/lib/_blink/dartium/_blink_dartium.dart#newcode977 sdk/lib/_blink/dartium/_blink_dartium.dart:977: Native_CanvasRenderingContext2D__fill_1_Callback(mthis, winding) native "CanvasRenderingContext2D_fill_Callback_1_CanvasWindingRule"; Well, currently both generate CanvasWindingRule. ...
6 years, 7 months ago (2014-05-14 22:57:23 UTC) #3
Jacob
lgtm
6 years, 7 months ago (2014-05-14 23:23:03 UTC) #4
Leaf
6 years, 7 months ago (2014-05-14 23:28:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r36196 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698