Add isFinite getter to num.

Add isFinite getter to num.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29067

[floitsch, 2013-10-18 11:54:59]

LGTM.

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart#newcode156
sdk/lib/core/num.dart:156: * Whether the number is the double positive or
negative infinity.
double reads bad here.

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart#newcode163
sdk/lib/core/num.dart:163: * The only non-finite numbers are NaN and positive or
negative infinity.
nit. I prefer:
NaN, positive infinity and negative infinity.

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
File tests/corelib/nan_infinity_test.dart (right):

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
tests/corelib/nan_infinity_test.dart:50: Expect.isTrue(identical(double.NAN,
double.NAN));
sure this won't break dart2js?
if yes it should probably be in a separate file or a multi test, and require a
status-file update.

[floitsch, 2013-10-18 11:55:15]

Also I think the doc-writers don't like "wether x or y" in the dartdocs.

[Lasse Reichstein Nielsen, 2013-10-22 16:31:45]

What would be the preferred alternative to "Whether foo" for boolean functions?

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
File tests/corelib/nan_infinity_test.dart (right):

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
tests/corelib/nan_infinity_test.dart:50: Expect.isTrue(identical(double.NAN,
double.NAN));
The test runs, but I didn't check if it was because it was already marked as
failing.

[Kathy Walrath, 2013-10-22 16:40:02]

On 2013/10/22 16:31:45, Lasse Reichstein Nielsen wrote:
> What would be the preferred alternative to "Whether foo" for boolean
functions?

For a getter, I think we'd prefer "True if ...; otherwise, false".

For a method/function, it's usually "Returns true if ..."

[Lasse Reichstein Nielsen, 2013-10-23 10:21:23]

Committed patchset #3 manually as r29067 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-10-23 10:21:37]

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart#newcode156
sdk/lib/core/num.dart:156: * Whether the number is the double positive or
negative infinity.
On 2013/10/18 11:54:59, floitsch wrote:
> double reads bad here.

Done.

https://codereview.chromium.org/28973002/diff/1/sdk/lib/core/num.dart#newcode163
sdk/lib/core/num.dart:163: * The only non-finite numbers are NaN and positive or
negative infinity.
On 2013/10/18 11:54:59, floitsch wrote:
> nit. I prefer:
> NaN, positive infinity and negative infinity.

Done.

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
File tests/corelib/nan_infinity_test.dart (right):

https://codereview.chromium.org/28973002/diff/1/tests/corelib/nan_infinity_te...
tests/corelib/nan_infinity_test.dart:50: Expect.isTrue(identical(double.NAN,
double.NAN));
Turned into multi-test that fails for dart2js.