Issue 28943003: dart:io | Remove deprecated behavior of Directory('').createTemp, replaced by Directory.systemTemp.

Issue 28943003: dart:io | Remove deprecated behavior of Directory('').createTemp, replaced by Directory.systemTemp. (Closed)

Created:
7 years, 2 months ago by Bill Hesse

Modified:
7 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Remove deprecated behavior of Directory('').createTemp, replaced by Directory.systemTemp. BUG=dartbug.com/13720 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28920

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -16 lines)			Patch
	M	sdk/lib/io/directory.dart	View		2 chunks	+0 lines, -10 lines	0 comments	Download
	M	sdk/lib/io/directory_impl.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #1 manually as r28920 (presubmit successful).

7 years, 2 months ago (2013-10-21 08:23:48 UTC) #3

srdjan

On 2013/10/21 08:23:48, Bill Hesse wrote: > Committed patchset #1 manually as r28920 (presubmit successful). ...

7 years, 2 months ago (2013-10-22 23:16:00 UTC) #4

Bill Hesse

7 years, 2 months ago (2013-10-23 07:22:32 UTC) #5

Message was sent while issue was closed.

On 2013/10/22 23:16:00, srdjan wrote:
> On 2013/10/21 08:23:48, Bill Hesse wrote:
> > Committed patchset #1 manually as r28920 (presubmit successful).
> 
> This CL broke FileIO benchmark. Could you please fix.
> 
> Unhandled exception:
> Illegal argument(s): Directory.createTemp called with an empty path. To use
the
> system temp directory, use Directory.systemTemp
> #0      _Directory.createTempSync (directory_impl.dart:178)
> #1      FileIOBenchmark.setup
> (file:///sources/race-dart/dart/benchmarks/FileIO/dart-io/FileIO.dart:123:44)
> #2      IOBenchmarkBase.measure
>
(file:///sources/race-dart/dart/benchmarks/common/dart-io/IOBenchmarkBase.dart:61:10)
> #3      IOBenchmarkBase.report
>
(file:///sources/4042race-dart/dart/benchmarks/common/dart-io/IOBenchmarkBase.dart:74:12)
> #4      main
> (file:///sources/race-dart/dart/benchmarks/FileIO/dart-io/FileIO.dart:173:64)

Fix for FileIO benchmark committed as r4042

Expand Messages | Collapse Messages