Issue 289353002: Add SetBase/SetMixin.

Issue 289353002: Add SetBase/SetMixin. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add SetBase/SetMixin. Depends on adding cloneEmpty method to Set class and toSet creating a clone. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36478

Patch Set 2 : Updated to not use cloneEmpty #

Total comments: 4

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+318 lines, -176 lines)			Patch
M	runtime/lib/collection_patch.dart	View	1	3 chunks	+0 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View	1	5 chunks	+0 lines, -57 lines	0 comments	Download
M	sdk/lib/collection/collection.dart	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	sdk/lib/collection/collection_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	1	2 chunks	+12 lines, -40 lines	2 comments	Download
A	sdk/lib/collection/set.dart	View	1	1 chunk	+290 lines, -0 lines	2 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	1	6 chunks	+8 lines, -61 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

floitsch

FYI. https://codereview.chromium.org/289353002/diff/1/sdk/lib/collection/set.dart File sdk/lib/collection/set.dart (right): https://codereview.chromium.org/289353002/diff/1/sdk/lib/collection/set.dart#newcode24 sdk/lib/collection/set.dart:24: * or be combined with [IterableMixin]. This is ...

6 years, 7 months ago (2014-05-19 13:13:43 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/289353002/diff/20001/sdk/lib/collection/hash_set.dart File sdk/lib/collection/hash_set.dart (right): https://codereview.chromium.org/289353002/diff/20001/sdk/lib/collection/hash_set.dart#newcode12 sdk/lib/collection/hash_set.dart:12: // unlike SetBase which starts from toSet() and ...

6 years, 7 months ago (2014-05-22 09:25:52 UTC) #5

Lasse Reichstein Nielsen

https://codereview.chromium.org/289353002/diff/20001/sdk/lib/collection/hash_set.dart File sdk/lib/collection/hash_set.dart (right): https://codereview.chromium.org/289353002/diff/20001/sdk/lib/collection/hash_set.dart#newcode12 sdk/lib/collection/hash_set.dart:12: // unlike SetBase which starts from toSet() and removes ...

6 years, 7 months ago (2014-05-22 09:41:36 UTC) #6

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-05-22 09:48:34 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r36478 (presubmit successful).

Expand Messages | Collapse Messages