Issue 289333004: Fixes bug in megamorphic instance call on arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289333004: Fixes bug in megamorphic instance call on arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis, Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes bug in megamorphic instance call on arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36306

Patch Set 1 #

Total comments: 5

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	runtime/vm/flow_graph_compiler_arm64.cc	View		2 chunks	+3 lines, -3 lines	5 comments	Download
	M	tests/language/language.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Committed patchset #1 manually as r36306 (presubmit successful).

6 years, 7 months ago (2014-05-19 16:48:12 UTC) #3

Florian Schneider

6 years, 7 months ago (2014-05-20 13:12:48 UTC) #4

Message was sent while issue was closed.

DBC:

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm64.cc (left):

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1282: __ add(TMP, R2, Operand(R3, LSL,
2));
Use kWordSizeLog2 instead.

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1296: __ add(TMP, R2, Operand(R3, LSL,
2));
Use kWordSizeLog2 instead.

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1281: // R3 is smi tagged, but table
entries are 16 bytes, so LSL 3.
...entries are 2 words, so use LSL kWordSizeLog2.

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1282: __ add(TMP, R2, Operand(R3, LSL,
3));
Use kWordSizeLog2 instead.

https://codereview.chromium.org/289333004/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1296: __ add(TMP, R2, Operand(R3, LSL,
3));
Use kWordSizeLog2 instead.

Expand Messages | Collapse Messages