Chromium Code Reviews

Issue 288983011: Update pub's isolate load error parsing code. (Closed)

Created:
6 years, 7 months ago by nweiz
Modified:
6 years, 7 months ago
Reviewers:
Bob Nystrom, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update pub's isolate load error parsing code. The VM's isolate load error messages changed so we need to change our parsing. R=hausner@google.com, rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=36600

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+1 line, -5 lines)
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 chunk +1 line, -1 line 2 comments
M sdk/lib/_internal/pub/pub.status View 1 chunk +0 lines, -4 lines 0 comments

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 7 months ago (2014-05-23 23:03:40 UTC) #1
hausner
LGTM. I hope it's a simple as that. Thank you very much! https://codereview.chromium.org/288983011/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart ...
6 years, 7 months ago (2014-05-23 23:20:34 UTC) #2
nweiz
https://codereview.chromium.org/288983011/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (left): https://codereview.chromium.org/288983011/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#oldcode58 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:58: if (error is! CrossIsolateException) throw error; On 2014/05/23 23:20:34, ...
6 years, 7 months ago (2014-05-23 23:22:05 UTC) #3
hausner
The more you know...
6 years, 7 months ago (2014-05-23 23:23:40 UTC) #4
Bob Nystrom
lgtm
6 years, 7 months ago (2014-05-24 00:11:17 UTC) #5
nweiz
6 years, 7 months ago (2014-05-24 00:12:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r36600 (presubmit successful).

Powered by Google App Engine