More improvements to ARM array load code.

More improvements to ARM array load code.

This CL improves the address computation for tagged loads.

tbr=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36213

[Florian Schneider, 2014-05-14 15:02:35]

Another follow-up improvement to selecting better addressing modes for array
loads.

Once I found a good way to structure address compuations more general, I'll also
tackle stores in the same fashion.

[zra, 2014-05-14 16:32:44]

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1244: if (!IsExternal()) {
Looks like you can hoist these out of the switch statement.

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1247: element_address =
Address(index.reg(), offset);
Same comment as in the other CL for the range of offset.

[Florian Schneider, 2014-05-15 09:43:26]

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1244: if (!IsExternal()) {
On 2014/05/14 16:32:44, zra wrote:
> Looks like you can hoist these out of the switch statement.

Done.

https://codereview.chromium.org/288723002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1247: element_address =
Address(index.reg(), offset);
On 2014/05/14 16:32:44, zra wrote:
> Same comment as in the other CL for the range of offset.

Done.

[Florian Schneider, 2014-05-15 11:34:30]

Committed patchset #1 manually as r36213 (presubmit successful).