Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 288703003: Revert revisions 36163 and 36162 (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert revisions 36163 and 36162 Committed: https://code.google.com/p/dart/source/detail?r=36165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -74 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 7 chunks +9 lines, -46 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-14 13:39:56 UTC) #1
ricow1
TBR This is making windows fail - investigating locally
6 years, 7 months ago (2014-05-14 13:41:50 UTC) #2
ricow1
Committed patchset #1 manually as r36165 (presubmit successful).
6 years, 7 months ago (2014-05-14 13:42:05 UTC) #3
Bill Hesse
6 years, 7 months ago (2014-05-14 14:00:25 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698