dart2dart: Test cases for better code coverage in dart_tree rewritings.

dart2dart: Test cases for better code coverage in dart_tree rewritings.

Also:
- fixes a pattern matching bug revealed by a test.
- contains a tool for profiling multiple compilations in Dart Observatory.

BUG=
R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36678

[asgerf, 2014-05-22 13:49:35]

Bash script in case want to look at the code coverage:

DART=<dart repository>/dart
dart -DUSE_NEW_BACKEND=true \
    --enable-checked-mode \
    --enable-vm-service \
    --pause-isolates-on-exit \
    $DART/sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart \
    -p$DART/out/ReleaseIA32/packages \
    --output-type=dart \
    tests/language/rewrite_*_test.dart

Then open localhost:8181.

https://codereview.chromium.org/288343014/diff/1/tests/language/if_flatten1_t...
File tests/language/if_flatten1_test.dart (left):

https://codereview.chromium.org/288343014/diff/1/tests/language/if_flatten1_t...
tests/language/if_flatten1_test.dart:1: // Copyright (c) 2014, the Dart project
authors.  Please see the AUTHORS file
Renamed to rewrite_nested_if1_test.dart

https://codereview.chromium.org/288343014/diff/1/tests/language/rewrite_assig...
File tests/language/rewrite_assign_test.dart (right):

https://codereview.chromium.org/288343014/diff/1/tests/language/rewrite_assig...
tests/language/rewrite_assign_test.dart:6: 
This file (rewrite_assign_test.dart) did not exist before. I don't know why the
diff behaves this way.

[asgerf, 2014-05-27 11:44:35]

Bump. Could someone take a look when you have the time?

[sigurdm, 2014-05-27 12:05:34]

LGTM

I don't know the policy for making internal scripts - but maybe it would be
better located in tools/ - and I think the bash script should be somewhere, so
the tests are reproducible - I guess it would be hard to make it as a real test
that runs on the bots?

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart
(right):

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart:15: This for
profiling multiple compilations in the Dart Observatory.
This for => This is for

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart:44:
compileFile(int index) {
Maybe iterating through the files and compiling each would be easier with
Future.forEach

https://codereview.chromium.org/288343014/diff/1/tests/language/rewrite_assig...
File tests/language/rewrite_assign_test.dart (right):

https://codereview.chromium.org/288343014/diff/1/tests/language/rewrite_assig...
tests/language/rewrite_assign_test.dart:6: 
On 2014/05/22 13:49:35, asgerf wrote:
> This file (rewrite_assign_test.dart) did not exist before. I don't know why
the
> diff behaves this way.
It tries to find a similar file.
git cl upload takes an argument --no-find-copies that disables this.

[asgerf, 2014-05-27 12:25:33]

There is a file dart2js_stress.dart in the same folder and this seemed related.

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart
(right):

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart:15: This for
profiling multiple compilations in the Dart Observatory.
On 2014/05/27 12:05:34, sigurdm wrote:
> This for => This is for

Done.

https://codereview.chromium.org/288343014/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js_profile_many.dart:44:
compileFile(int index) {
On 2014/05/27 12:05:34, sigurdm wrote:
> Maybe iterating through the files and compiling each would be easier with
> Future.forEach

Much better, thanks.

[sigurdm, 2014-05-27 12:31:59]

Right - that seems like the same kind of tool.

[asgerf, 2014-05-27 13:39:51]

Committed patchset #5 manually as r36678 (presubmit successful).