Issue 288343010: Fix inlining tree printing to skip duplicates as the gathered inlined info is aggregated from many …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 288343010: Fix inlining tree printing to skip duplicates as the gathered inlined info is aggregated from many … (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix inlining tree printing to skip duplicates as the gathered inlined info is aggregated from many different inlines. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36437

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View	1 2	5 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://codereview.chromium.org/288343010/diff/20001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/288343010/diff/20001/runtime/vm/flow_graph_inliner.cc#newcode821 runtime/vm/flow_graph_inliner.cc:821: static bool ExistsIn(const GrowableArray<intptr_t>& a, intptr_t deopt_id) { ...

6 years, 7 months ago (2014-05-21 15:15:28 UTC) #2

srdjan

https://codereview.chromium.org/288343010/diff/20001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/288343010/diff/20001/runtime/vm/flow_graph_inliner.cc#newcode821 runtime/vm/flow_graph_inliner.cc:821: static bool ExistsIn(const GrowableArray<intptr_t>& a, intptr_t deopt_id) { On ...

6 years, 7 months ago (2014-05-21 15:24:27 UTC) #3

srdjan

6 years, 7 months ago (2014-05-21 16:34:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36437 (presubmit successful).

Expand Messages | Collapse Messages