Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 288113008: Fix status files, move header down to not shadow existing full suppressions, remove suppression fro… (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix status files, move header down to not shadow existing full suppressions, remove suppression from pkgbuild, it does not run on dartium R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=36426

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M pkg/pkgbuild.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 7 months ago (2014-05-21 11:51:37 UTC) #1
vsm
lgtm I already tbr'ed the pkg.status fix to you.
6 years, 7 months ago (2014-05-21 11:52:37 UTC) #2
ricow1
Changed to only fix pkgbuild, the pkg status has already been updated
6 years, 7 months ago (2014-05-21 11:52:53 UTC) #3
vsm
lgtm - thanks!
6 years, 7 months ago (2014-05-21 11:53:56 UTC) #4
ricow1
6 years, 7 months ago (2014-05-21 12:02:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698