allow client to specify any combination of add/modified/removed

allow client to specify any combination of add/modified/removed

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36216

[Paul Berry, 2014-05-15 00:30:54]

lgtm

https://codereview.chromium.org/288013003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/288013003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:191: return datum is Map<String,
dynamic> && datum.containsKey(key);
This means that if we receive a datum from the client that has a non-map where a
map was expected, we will silently act like the datum was the empty map.

I'd prefer to generate an error in that case (as we do in operator[],
forEachMap, and asStringMap) so that we help detect bugs in the client.

[Brian Wilkerson, 2014-05-15 02:34:52]

LGTM

[danrubel, 2014-05-15 11:48:44]

https://codereview.chromium.org/288013003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/288013003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:191: return datum is Map<String,
dynamic> && datum.containsKey(key);
On 2014/05/15 00:30:54, Paul Berry wrote:
> This means that if we receive a datum from the client that has a non-map where
a
> map was expected, we will silently act like the datum was the empty map.
> 
> I'd prefer to generate an error in that case (as we do in operator[],
> forEachMap, and asStringMap) so that we help detect bugs in the client.

Good suggestion. Done.

[danrubel, 2014-05-15 11:49:27]

Committed patchset #2 manually as r36216 (presubmit successful).