Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 287523003: Improve error messages in MirrorSystem.findLibrary. (Closed)

Created:
6 years, 7 months ago by rmacnak
Modified:
6 years, 7 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve error messages in MirrorSystem.findLibrary. BUG=http://dartbug.com/18532 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=36114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M runtime/lib/mirrors_patch.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
Redo without removing the implementation from sdk/.../mirrors.dart used by source mirrors.
6 years, 7 months ago (2014-05-12 21:46:52 UTC) #1
gbracha
lgtm
6 years, 7 months ago (2014-05-12 22:02:37 UTC) #2
rmacnak
6 years, 7 months ago (2014-05-13 17:20:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698