Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2872233002: Make `TypeSafeStream` extend `Stream`. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, nweiz
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make `TypeSafeStream` extend `Stream`. This makes it automatically compatible with future additions to `Stream`, like the `groupBy` method which will be added in SDK version 1.24. It inherits the default implementation, which will use the `listen` method of the `TypeSafeStream`, returning a `TypeSafeStreamSubscription`, and will just have a type check for each event before the listener even sees it. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/async/commit/daf66909019d2aaec1721fc39d94ea648a9fdc1d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +9 lines, -0 lines 0 comments Download
M lib/src/typed/stream.dart View 1 chunk +1 line, -1 line 1 comment Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-10 07:48:20 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2872233002/diff/1/lib/src/typed/stream.dart File lib/src/typed/stream.dart (right): https://codereview.chromium.org/2872233002/diff/1/lib/src/typed/stream.dart#newcode13 lib/src/typed/stream.dart:13: class TypeSafeStream<T> extends Stream<T> { should we add ...
3 years, 7 months ago (2017-05-16 09:01:18 UTC) #3
floitsch
3 years, 7 months ago (2017-05-16 12:55:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
daf66909019d2aaec1721fc39d94ea648a9fdc1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698