Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 287053006: Only disable tests when compiler is none (Closed)

Created:
6 years, 7 months ago by Leaf
Modified:
6 years, 7 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Only disable tests when compiler is none Allow more polymer tests in dartium to fail BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=36445

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add line between sections #

Patch Set 3 : Fix comments #

Patch Set 4 : Missed one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pkg/pkg.status View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M tests/html/html.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Leaf
6 years, 7 months ago (2014-05-21 18:56:53 UTC) #1
vsm
lgtm https://codereview.chromium.org/287053006/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/287053006/diff/1/pkg/pkg.status#newcode27 pkg/pkg.status:27: polymer/test/custom_event_test: Pass, RuntimeError # Issue number 18931 Nit: ...
6 years, 7 months ago (2014-05-21 18:59:03 UTC) #2
Leaf
https://codereview.chromium.org/287053006/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/287053006/diff/1/pkg/pkg.status#newcode27 pkg/pkg.status:27: polymer/test/custom_event_test: Pass, RuntimeError # Issue number 18931 On 2014/05/21 ...
6 years, 7 months ago (2014-05-21 19:29:08 UTC) #3
Leaf
6 years, 7 months ago (2014-05-21 20:05:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r36445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698