Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 286903020: Fix crash when parsing metadata that refers to a static getter. (Closed)

Created:
6 years, 7 months ago by rmacnak
Modified:
6 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix crash when parsing metadata that refers to a static getter. BUG=http://dartbug.com/18949 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/mirrors/metadata_allowed_values_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
6 years, 7 months ago (2014-05-22 18:29:33 UTC) #1
hausner
LGTM as a auick fix, but at some time we should think of a more ...
6 years, 7 months ago (2014-05-22 18:35:59 UTC) #2
rmacnak
On 2014/05/22 18:35:59, hausner wrote: > LGTM as a auick fix, but at some time ...
6 years, 7 months ago (2014-05-22 18:38:23 UTC) #3
rmacnak
On 2014/05/22 18:38:23, rmacnak wrote: > On 2014/05/22 18:35:59, hausner wrote: > > LGTM as ...
6 years, 7 months ago (2014-05-22 18:41:01 UTC) #4
rmacnak
6 years, 7 months ago (2014-05-22 18:56:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r36522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698