Issue 286903010: Add dart:io view to the observatory.

Issue 286903010: Add dart:io view to the observatory. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add dart:io view to the observatory. The dart:io view contains HttpServerList and HttpServer for now. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36559

Patch Set 2 : Remove debug print. #

Patch Set 3 : Add missing files. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4678 lines, -2018 lines)			Patch
M	runtime/bin/service_object_patch.dart	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2	5 chunks	+1168 lines, -156 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	253 chunks	+978 lines, -783 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2	5 chunks	+1168 lines, -156 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	243 chunks	+1065 lines, -858 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/elements.html	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html	View	1 2	1 chunk	+36 lines, -31 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/elements.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/elements.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/elements/io_view.dart	View	1 2	1 chunk	+73 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/elements/io_view.html	View	1 2	1 chunk	+103 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html	View	1 2	1 chunk	+36 lines, -31 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/json_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/service_view.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with comments https://codereview.chromium.org/286903010/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/286903010/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode704 runtime/bin/vmservice/client/lib/src/service/object.dart:704: print(features); remove before commit https://codereview.chromium.org/286903010/diff/1/runtime/vm/isolate.cc File ...

6 years, 7 months ago (2014-05-23 05:51:37 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/286903010/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/286903010/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode704 runtime/bin/vmservice/client/lib/src/service/object.dart:704: print(features); On 2014/05/23 05:51:37, Cutch wrote: > remove ...

6 years, 7 months ago (2014-05-23 05:59:13 UTC) #3

Anders Johnsen

6 years, 7 months ago (2014-05-23 10:10:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36559 (presubmit successful).

Expand Messages | Collapse Messages