Issue 286363006: Add flag —enable-debugger (default true) in order to disable debugger single stepping code.

Issue 286363006: Add flag —enable-debugger (default true) in order to disable debugger single stepping code. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added flags: --enable-debugger (default true) --emit-edge-counters (default true) --use_field_guards (default true) These flags can be turned off in order to measure their impact on code. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36537

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 5

Patch Set 9 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+353 lines, -267 lines)			Patch
M	runtime/vm/block_scheduler.cc	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4 5 6 7	4 chunks	+18 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5 6	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5 6 7	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5 6	2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4 5 6 7 8	5 chunks	+53 lines, -44 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3 4 5 6 7 8	5 chunks	+58 lines, -48 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5 6 7 8	5 chunks	+53 lines, -44 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3 4 5 6 7 8	5 chunks	+69 lines, -61 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5 6 7 8	5 chunks	+53 lines, -44 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with enhancements discussed out-of-band. -Ivan https://codereview.chromium.org/286363006/diff/80001/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (right): https://codereview.chromium.org/286363006/diff/80001/runtime/vm/stub_code_ia32.cc#newcode1305 runtime/vm/stub_code_ia32.cc:1305: if (FLAG_enable_debugger) { ...

6 years, 7 months ago (2014-05-22 21:53:42 UTC) #1

hausner

LGTM but there are several places in the stub_code_XXX files where you can add runtime ...

6 years, 7 months ago (2014-05-22 23:28:07 UTC) #3

srdjan

https://codereview.chromium.org/286363006/diff/140001/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/286363006/diff/140001/runtime/vm/stub_code_arm.cc#newcode1579 runtime/vm/stub_code_arm.cc:1579: Label not_stepping; On 2014/05/22 23:28:08, hausner wrote: > ditto ...

6 years, 7 months ago (2014-05-22 23:38:26 UTC) #4

srdjan

6 years, 7 months ago (2014-05-22 23:47:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #9 manually as r36537 (presubmit successful).

Expand Messages | Collapse Messages