Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 286063006: Make directory_list_sync_test faster (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 7 months ago
Reviewers:
ricow1, Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make directory_list_sync_test faster Let it iterate over 20000 entries instead of 200000 by starting in dart/tests instead of dart. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=36309

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/standalone/io/directory_list_sync_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
6 years, 7 months ago (2014-05-19 17:28:19 UTC) #1
ricow1
+ajohnsen fyi LGTM https://codereview.chromium.org/286063006/diff/1/tests/standalone/io/directory_list_sync_test.dart File tests/standalone/io/directory_list_sync_test.dart (right): https://codereview.chromium.org/286063006/diff/1/tests/standalone/io/directory_list_sync_test.dart#newcode9 tests/standalone/io/directory_list_sync_test.dart:9: // tests/standalone/io/../../.. update comment https://codereview.chromium.org/286063006/diff/1/tests/standalone/io/directory_list_sync_test.dart#newcode11 tests/standalone/io/directory_list_sync_test.dart:11: ...
6 years, 7 months ago (2014-05-19 17:40:22 UTC) #2
hausner
Thank you. https://codereview.chromium.org/286063006/diff/1/tests/standalone/io/directory_list_sync_test.dart File tests/standalone/io/directory_list_sync_test.dart (right): https://codereview.chromium.org/286063006/diff/1/tests/standalone/io/directory_list_sync_test.dart#newcode9 tests/standalone/io/directory_list_sync_test.dart:9: // tests/standalone/io/../../.. On 2014/05/19 17:40:22, ricow1 wrote: ...
6 years, 7 months ago (2014-05-19 17:43:42 UTC) #3
hausner
6 years, 7 months ago (2014-05-19 17:44:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698