Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285903006: Fix main handling in dart2js and add tests. (Closed)

Created:
6 years, 7 months ago by ahe
Modified:
6 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix main handling in dart2js and add tests. BUG=https://code.google.com/p/dart/issues/detail?id=5683 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38187

Patch Set 1 #

Patch Set 2 : Merged with r38156 (including changes to findHelper and main arity test). #

Patch Set 3 : Updated tests. #

Patch Set 4 : Update co19 status #

Total comments: 3

Patch Set 5 : Implement in dart2dart as well. #

Patch Set 6 : co19 status #

Patch Set 7 : Merged with r38186. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -53 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 4 5 6 8 chunks +77 lines, -49 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/deferred_load.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/warnings.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/lib/js_helper.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download
M dart/tests/co19/co19-dart2dart.status View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/language.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + dart/tests/language/main_not_a_function_test.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
A dart/tests/language/main_test.dart View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A + dart/tests/language/no_main_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ahe
A refactoring gone wrong :-)
6 years, 7 months ago (2014-05-14 15:52:26 UTC) #1
ahe
See also https://code.google.com/p/dart/issues/detail?id=18812
6 years, 7 months ago (2014-05-14 15:53:54 UTC) #2
Johnni Winther
lgtm
6 years, 7 months ago (2014-05-15 07:16:13 UTC) #3
ahe
Turns out that the second argument is used by Isolate.spawnUri. I'm currently awaiting an updated ...
6 years, 7 months ago (2014-05-15 09:47:35 UTC) #4
ahe
PTAL
6 years, 5 months ago (2014-07-11 12:39:28 UTC) #5
Johnni Winther
https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1332 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:1332: internalError(mainApp, 'Unable to find method "$MAIN".'); dart2dart will result ...
6 years, 5 months ago (2014-07-11 13:19:26 UTC) #6
ahe
https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1332 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:1332: internalError(mainApp, 'Unable to find method "$MAIN".'); On 2014/07/11 13:19:26, ...
6 years, 5 months ago (2014-07-11 13:24:01 UTC) #7
Johnni Winther
https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/285903006/diff/80001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1332 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:1332: internalError(mainApp, 'Unable to find method "$MAIN".'); On 2014/07/11 13:24:01, ...
6 years, 5 months ago (2014-07-13 12:31:44 UTC) #8
ahe
PTAL. I went a step further so the bug is also fixed in dart2dart.
6 years, 5 months ago (2014-07-14 09:57:57 UTC) #9
Johnni Winther
Still LGTM
6 years, 5 months ago (2014-07-14 10:26:04 UTC) #10
ahe
6 years, 5 months ago (2014-07-14 11:53:44 UTC) #11
Message was sent while issue was closed. 
Committed patchset #7 manually as r38187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698