Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issue 2857383002: Fix write to sink after close in test code. (Closed)

Created:
3 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/discovery_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-04 11:56:35 UTC) #2
floitsch
LGTM.
3 years, 7 months ago (2017-05-04 13:27:35 UTC) #3
Lasse Reichstein Nielsen
3 years, 7 months ago (2017-05-04 14:13:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cd94ff673fd5cf8e37af458296851d7b8f48f3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698