Issue 28553006: dart:io | Fix File.rename on Windows to overwrite an existing target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28553006: dart:io | Fix File.rename on Windows to overwrite an existing target. (Closed)

Created:
7 years, 2 months ago by Bill Hesse

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:io | Fix File.rename on Windows to overwrite an existing target. BUG=dartbug.com/14164 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28933

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -41 lines)			Patch
	M	runtime/bin/file_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tests/standalone/io/file_test.dart	View	1 2 3	2 chunks	+42 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

The "if Platform.isWindows" part of the test should be moved to link tests, but I'll ...

7 years, 2 months ago (2013-10-21 10:51:59 UTC) #1

Bill Hesse

7 years, 2 months ago (2013-10-21 14:57:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r28933 (presubmit successful).