Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 285463002: pkg/docgen: ensure parameter maps keep their key order (Closed)

Created:
6 years, 7 months ago by kevmoo
Modified:
6 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: ensure parameter maps keep their key order Committed: https://code.google.com/p/dart/source/detail?r=36038

Patch Set 1 #

Patch Set 2 : make ordering opt-in at the right places #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -22 lines) Patch
M pkg/docgen/lib/src/models/model_helpers.dart View 1 7 chunks +19 lines, -19 lines 0 comments Download
M pkg/docgen/test/constant_argument_test.dart View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
This is a pretty gnarly oversight on my part. I'll push to get this into ...
6 years, 7 months ago (2014-05-12 15:20:42 UTC) #1
kevmoo
Committed patchset #2 manually as r36038 (presubmit successful).
6 years, 7 months ago (2014-05-12 16:03:10 UTC) #2
Emily Fortuna
6 years, 7 months ago (2014-05-12 16:03:12 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698