Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 285423002: New analyzer snapshot (with CaughtException). (Closed)

Created:
6 years, 7 months ago by scheglov
Modified:
6 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

New analyzer snapshot (with CaughtException). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36256

Patch Set 1 #

Patch Set 2 : Replace AnalysisException with CaughtException #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2190 lines, -856 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/context/AnalysisException.java View 3 chunks +7 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/AnalysisTask.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/ParseHtmlTask.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/ScanDartTask.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/SimpleResolverTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/timing/SDKAnalysisTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 1 1 chunk +85 lines, -0 lines 0 comments Download
A editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineExceptionProcessor.java View 1 1 chunk +149 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 11 chunks +139 lines, -101 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 25 chunks +585 lines, -208 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 7 chunks +19 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 102 chunks +127 lines, -159 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 140 chunks +256 lines, -228 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 1 4 chunks +73 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 44 chunks +126 lines, -61 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 6 chunks +62 lines, -4 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +20 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 39 chunks +426 lines, -36 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 7 months ago (2014-05-15 18:20:40 UTC) #1
Brian Wilkerson
This is really useful, thanks! I like the way the new code pattern looks (and ...
6 years, 7 months ago (2014-05-15 20:16:09 UTC) #2
scheglov
PTAL On 2014/05/15 20:16:09, Brian Wilkerson wrote: > This is really useful, thanks! I like ...
6 years, 7 months ago (2014-05-15 22:15:33 UTC) #3
Brian Wilkerson
LGTM. Thanks!
6 years, 7 months ago (2014-05-16 00:53:31 UTC) #4
scheglov
6 years, 7 months ago (2014-05-16 01:45:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698