Issue 285043003: Two related changes that both affect how cursor positions might change on single line edits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285043003: Two related changes that both affect how cursor positions might change on single line edits. (Closed)

Created:
6 years, 7 months ago by ahe

Modified:
6 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, lukechurch, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Two related changes that both affect how cursor positions might change on single line edits. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=36208

Patch Set 2 : Merged with r36207. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -9 lines)			Patch
M	dart/site/try/src/interaction_manager.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	dart/site/try/src/selection.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	dart/tests/try/cursor_position_test.dart	View		2 chunks	+39 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/285043003/diff/1/dart/tests/try/cursor_position_test.dart File dart/tests/try/cursor_position_test.dart (right): https://codereview.chromium.org/285043003/diff/1/dart/tests/try/cursor_position_test.dart#newcode26 dart/tests/try/cursor_position_test.dart:26: new TestCase('Test adding a new text node.', () { ...

6 years, 7 months ago (2014-05-14 12:07:40 UTC) #1

ahe

6 years, 7 months ago (2014-05-15 10:11:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36208 (presubmit successful).

Expand Messages | Collapse Messages

Issue 285043003: Two related changes that both affect how cursor positions might change on single line edits. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merged with r36207. #

Messages