Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285023002: Fix listening for multiple signals. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix listening for multiple signals. BUG=https://code.google.com/p/dart/issues/detail?id=18793 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36153

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -38 lines) Patch
M runtime/bin/process.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/process_android.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/bin/process_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tests/standalone/io/signal_test_script.dart View 1 chunk +16 lines, -14 lines 0 comments Download
M tests/standalone/io/signals_test.dart View 3 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-14 07:29:19 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/285023002/diff/1/runtime/bin/process.h File runtime/bin/process.h (right): https://codereview.chromium.org/285023002/diff/1/runtime/bin/process.h#newcode141 runtime/bin/process.h:141: SignalInfo(int fd, int signal, SignalInfo* next = NULL) ...
6 years, 7 months ago (2014-05-14 09:04:13 UTC) #2
Anders Johnsen
https://codereview.chromium.org/285023002/diff/1/runtime/bin/process.h File runtime/bin/process.h (right): https://codereview.chromium.org/285023002/diff/1/runtime/bin/process.h#newcode141 runtime/bin/process.h:141: SignalInfo(int fd, int signal, SignalInfo* next = NULL) On ...
6 years, 7 months ago (2014-05-14 09:30:16 UTC) #3
Anders Johnsen
6 years, 7 months ago (2014-05-14 09:36:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r36153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698