Build completion notification for Windows.

Support build completion notification on Windows.

Build notifications looks cool on Linux and Mac. Let Windows folks have fun with them too.

BUG=dartbug.com/18808
R=ahe@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36199

[aam-me, 2014-05-14 03:42:16]

Hi,

  I just learnt about build notifications on Linux and Mac.
  This CL enables these notifications on Windows as well.

  Hope that the powershell snippet is not too scary. :-)

Alexander Aprelev.

[ricow1, 2014-05-14 05:43:46]

https://chromiumcodereview.appspot.com/284743007/diff/20001/tools/build.py
File tools/build.py (right):

https://chromiumcodereview.appspot.com/284743007/diff/20001/tools/build.py#ne...
tools/build.py:341: command = ("powershell -command \""
where does the corresponding closing " appear, I don't see another /"
I assume this should be in line 350?

[ahe, 2014-05-14 06:06:34]

AFAIK, powershell is an optional download. But I guess that doesn't matter as
you have to opt-in to build notifications.

Am I reading the code correctly? It seems as if there are two icons. Why is
that?

[ricow1, 2014-05-14 06:09:16]

On 2014/05/14 06:06:34, ahe wrote:
> AFAIK, powershell is an optional download. But I guess that doesn't matter as
> you have to opt-in to build notifications.
And we ignore the failure if it does not work (although that could confuse
people, because they would assume that it worked if they set the environment
variable)
> 
> Am I reading the code correctly? It seems as if there are two icons. Why is
> that?

[aam-me, 2014-05-14 11:15:23]

On 2014/05/14 06:06:34, ahe wrote:
> AFAIK, powershell is an optional download. But I guess that doesn't matter as
> you have to opt-in to build notifications.

Powershell is bundled since Windows 7 I believe. Just not that many people use
it.

> Am I reading the code correctly? It seems as if there are two icons. Why is
> that?

One is icon in the systray, another is icon in the message itself.
Ideally we use Dart icon on line 347, but I'm not sure whether it's a 
good idea to use site\try\favicon.ico or 
editor\tools\plugins\com.google.dart.tools.deploy\icons\dart.ico.
So I left it with generic Information icon.

[aam-me, 2014-05-14 11:27:45]

Thank you Rico and Peter for taking a look.

I added missing quote. I'm surprised that Powershell didn't mind that.

https://chromiumcodereview.appspot.com/284743007/diff/20001/tools/build.py
File tools/build.py (right):

https://chromiumcodereview.appspot.com/284743007/diff/20001/tools/build.py#ne...
tools/build.py:341: command = ("powershell -command \""
Nice catch! Thank you.
Done.

[ricow1, 2014-05-14 11:31:39]

LGTM

[ahe, 2014-05-14 12:03:55]

lgtm

I didn't know that powershell was bundled since Windows 7.

[aam-me, 2014-05-15 01:02:07]

Committed patchset #3 manually as r36199 (presubmit successful).