Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 284693002: Refactor ssl3_send_client_verify. (Closed)

Created:
6 years, 7 months ago by davidben
Modified:
6 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/openssl.git@master
Visibility:
Public.

Description

Refactor ssl3_send_client_verify. The original logic was a confusing spaghetti and mixed up initialization for all the different cases together. Tidy it up in preparation for having to adjust this logic later to support asynchronous crypto operations. BUG=none R=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270417

Patch Set 1 #

Patch Set 2 : Add patch #

Patch Set 3 : Attempt to fix base URL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -67 lines) Patch
M README.chromium View 1 1 chunk +4 lines, -0 lines 0 comments Download
M openssl/ssl/s3_clnt.c View 3 chunks +55 lines, -67 lines 0 comments Download
A patches.chromium/0016-send_client_verify_cleanup.patch View 1 1 chunk +187 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davidben
This should be the same as the one landed in google3.
6 years, 7 months ago (2014-05-12 22:32:01 UTC) #1
agl
Rubber stamp LGTM since it was already reviewed internally.
6 years, 7 months ago (2014-05-12 23:05:40 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-05-13 21:57:15 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 22:00:08 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 7 months ago (2014-05-13 22:00:11 UTC) #5
davidben
6 years, 7 months ago (2014-05-14 16:27:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r270417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698