Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2844573002: Preserve type arguments in generic invocation expressions. (Closed)

Created:
3 years, 8 months ago by Bob Nystrom
Modified:
3 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Preserve type arguments in generic invocation expressions. Fix #621. It already handled generic *method* invocations like "foo<int>(1)". This fixes cases where the receiver is itself an expression, like "(<T>(T t) => t)<int>(1)". R=kevmoo@google.com Committed: https://github.com/dart-lang/dart_style/commit/f1181ddb46144d008f3d2cd3fb4211f23ffda95c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -1 line 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +9 lines, -1 line 0 comments Download
A test/regression/0600/0621.stmt View 1 chunk +8 lines, -0 lines 0 comments Download
M test/splitting/type_arguments.stmt View 1 chunk +30 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 8 months ago (2017-04-25 21:37:47 UTC) #2
kevmoo
lgtm
3 years, 8 months ago (2017-04-25 21:40:03 UTC) #3
Bob Nystrom
3 years, 8 months ago (2017-04-25 21:53:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1181ddb46144d008f3d2cd3fb4211f23ffda95c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698