implement ByteStreamClientChannel close

implement ByteStreamClientChannel close

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36316

[Paul Berry, 2014-05-16 18:01:27]

lgtm assuming comment is addressed.

https://codereview.chromium.org/284353002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/channel.dart (right):

https://codereview.chromium.org/284353002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/channel.dart:283: if (text == null || text.isEmpty
|| text[0] != '{') {
Is this an intentional part of the CL?  What's the purpose of the change?

At first blush it seems to me that we're better off just passing the text
through to JSON.decode() and letting it throw an exception if it's bad. 
Returning null for malformed input carries the risk of masking bugs.

[danrubel, 2014-05-19 17:32:25]

https://codereview.chromium.org/284353002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/channel.dart (right):

https://codereview.chromium.org/284353002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/channel.dart:283: if (text == null || text.isEmpty
|| text[0] != '{') {
On 2014/05/16 18:01:27, Paul Berry wrote:
> Is this an intentional part of the CL?  What's the purpose of the change?
> 
> At first blush it seems to me that we're better off just passing the text
> through to JSON.decode() and letting it throw an exception if it's bad. 
> Returning null for malformed input carries the risk of masking bugs.

This is to allow stack traces from the analysis server flow through to the
client, but maybe there is a better way to do this. I'll roll this back for now.

[danrubel, 2014-05-19 19:35:06]

Committed patchset #4 manually as r36316 (presubmit successful).