Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 284313011: Add IO service object handler, with initial implementation for HTTP server. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add IO service object handler, with initial implementation for HTTP server. This is tempoary disabling the Socket service handler. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -31 lines) Patch
M runtime/bin/io_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +28 lines, -27 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 5 chunks +33 lines, -4 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_cookie_date_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-21 11:05:11 UTC) #1
Cutch
lgtm
6 years, 7 months ago (2014-05-21 11:12:07 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-21 11:13:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698