Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 284103005: move context id constant to AnalysisServer (Closed)

Created:
6 years, 7 months ago by danrubel
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
Move constant to AnalysisServer so that it can be used in that class and elsewhere ...
6 years, 7 months ago (2014-05-16 15:30:22 UTC) #1
Paul Berry
lgtm I'm not sure I completely understand the benefit, though. I thought the idea was ...
6 years, 7 months ago (2014-05-16 15:38:13 UTC) #2
Brian Wilkerson
LGTM > So why are we going to need to use the constant from AnalysisServer ...
6 years, 7 months ago (2014-05-16 15:53:34 UTC) #3
danrubel
6 years, 7 months ago (2014-05-16 17:44:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r36263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698