Issue 284013002: Improve performance of stubcode based array allocation moving stub to isolate specific area.

Issue 284013002: Improve performance of stubcode based array allocation moving stub to isolate specific area. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve performance of stubcode based array allocation by moving stub to isolate specific area (quicker access to isolate fields). Remove _List. intrinsic. Performance fix in MIPS R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=36229

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 8

Patch Set 6 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+452 lines, -966 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 2 3 4 5	2 chunks	+1 line, -107 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 2 3 4 5	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3 4 5	2 chunks	+1 line, -108 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 2 3 4 5	2 chunks	+1 line, -114 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2 3 4 5	2 chunks	+1 line, -108 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4 5	1 chunk	+84 lines, -102 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3 4 5	1 chunk	+93 lines, -95 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	2 chunks	+96 lines, -114 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3 4 5	1 chunk	+90 lines, -102 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5	1 chunk	+82 lines, -109 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/284013002/diff/80001/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/284013002/diff/80001/runtime/vm/stub_code_arm.cc#newcode600 runtime/vm/stub_code_arm.cc:600: // R2: array length as Smi. (must be ...

6 years, 7 months ago (2014-05-15 16:20:26 UTC) #2

srdjan

https://codereview.chromium.org/284013002/diff/80001/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/284013002/diff/80001/runtime/vm/stub_code_arm.cc#newcode600 runtime/vm/stub_code_arm.cc:600: // R2: array length as Smi. (must be preserved) ...

6 years, 7 months ago (2014-05-15 16:52:34 UTC) #3

srdjan

6 years, 7 months ago (2014-05-15 16:58:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r36229 (presubmit successful).

Expand Messages | Collapse Messages