Issue 2837143003: Don't dump a stack trace on the user if the formatter had bad output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2837143003: Don't dump a stack trace on the user if the formatter had bad output. (Closed)

Created:
3 years, 8 months ago by Bob Nystrom

Modified:
3 years, 7 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -63 lines)			Patch
M	bin/format.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dart_style.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/src/dart_formatter.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	lib/src/error_listener.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	lib/src/exceptions.dart	View	1 chunk	+19 lines, -0 lines	0 comments	Download
D	lib/src/formatter_exception.dart	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	lib/src/io.dart	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	test/formatter_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 7 months ago (2017-04-25 18:26:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
23e672014b5b0ad2acec87cc539eebe8c9d02f8f (presubmit successful).