Issue 283513002: Adds far-branches to arm64.

Issue 283513002: Adds far-branches to arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds far-branches to arm64. Also fixes bugs and enables tests. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36051

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -93 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1 2	6 chunks	+64 lines, -13 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1 2	5 chunks	+84 lines, -10 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/find_code_object_test.cc	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2	8 chunks	+24 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/runtime_entry_arm64.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2	4 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2	2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	3 chunks	+7 lines, -27 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 2	1 chunk	+9 lines, -5 lines	0 comments	Download
M	tests/lib/math/double_pow_test.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

https://codereview.chromium.org/283513002/diff/1/runtime/vm/stub_code_arm64.cc File runtime/vm/stub_code_arm64.cc (right): https://codereview.chromium.org/283513002/diff/1/runtime/vm/stub_code_arm64.cc#newcode876 runtime/vm/stub_code_arm64.cc:876: __ PopDouble(r); This wasn't causing failures before because I ...

6 years, 7 months ago (2014-05-12 15:12:06 UTC) #1

regis

LGTM https://codereview.chromium.org/283513002/diff/20001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/283513002/diff/20001/runtime/vm/assembler_arm64.cc#newcode134 runtime/vm/assembler_arm64.cc:134: if (use_far_branches() /*&& !CanEncodeImm19BranchOffset(dest)*/) { Left over commented ...

6 years, 7 months ago (2014-05-12 16:05:01 UTC) #2

zra

Thanks! https://codereview.chromium.org/283513002/diff/20001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/283513002/diff/20001/runtime/vm/assembler_arm64.cc#newcode134 runtime/vm/assembler_arm64.cc:134: if (use_far_branches() /*&& !CanEncodeImm19BranchOffset(dest)*/) { On 2014/05/12 16:05:02, ...

6 years, 7 months ago (2014-05-12 18:42:50 UTC) #3

zra

6 years, 7 months ago (2014-05-12 18:43:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36051 (presubmit successful).

Expand Messages | Collapse Messages