Issue 283043003: Suppress cloning EventTarget methods in subtypes when using blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283043003: Suppress cloning EventTarget methods in subtypes when using blink (Closed)

Created:
6 years, 7 months ago by vsm

Modified:
6 years, 7 months ago

Reviewers:
Leaf, Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Suppress cloning EventTarget methods in subtypes when using blink I have an forthcoming Blink CL to safely cast to EventTarget*. Not sure this is the right path long term. Committed: https://code.google.com/p/dart/source/detail?r=36166

Patch Set 1 #

Patch Set 2 : Regen #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -781 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	1	39 chunks	+0 lines, -246 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		35 chunks	+0 lines, -453 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1	3 chunks	+0 lines, -36 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1	2 chunks	+0 lines, -27 lines	0 comments	Download
M	tools/dom/scripts/database.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #2 manually as r36166 (presubmit successful).

6 years, 7 months ago (2014-05-14 13:46:22 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages