Issue 282063004: Fix for issue 14116

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282063004: Fix for issue 14116 (Closed)

Created:
6 years, 7 months ago by Brian Wilkerson

Modified:
6 years, 7 months ago

Reviewers:
scheglov, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for issue 14116 R=jwren@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=36282

Patch Set 1 #

Patch Set 2 : Clean-up #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -48 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	8 chunks	+36 lines, -27 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		3 chunks	+20 lines, -20 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jwren

LGTM, but I'm not a familiar with the code being replaced as Konstantin. https://codereview.chromium.org/282063004/diff/20001/tests/lib/lib.status File ...

6 years, 7 months ago (2014-05-16 23:00:36 UTC) #2

Brian Wilkerson

6 years, 7 months ago (2014-05-17 02:23:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36282 (presubmit successful).

Expand Messages | Collapse Messages