Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 281983002: Add asserts to verify handle is always non null and the kIDENT literal (Closed)

Created:
6 years, 7 months ago by siva
Modified:
6 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add asserts to verify handle is always non null and the kIDENT literal is a symbol. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=36194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M runtime/vm/object.cc View 1 chunk +10 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
6 years, 7 months ago (2014-05-14 17:39:15 UTC) #1
Ivan Posva
LGTM -ip
6 years, 7 months ago (2014-05-14 22:21:29 UTC) #2
siva
6 years, 7 months ago (2014-05-14 22:25:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698