Issue 28193004: Attempt to fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28193004: Attempt to fix build. (Closed)

Created:
7 years, 2 months ago by scheglov

Modified:
7 years, 2 months ago

Reviewers:
Alan Knight, Brian Wilkerson, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempt to fix build. I have to restore CompilationUnit.lineInfo, because it is used by clients. Also added tweak to avoid using internal NodeList.elements, which was changed. TBR R=brianwilkerson@google.com,alanknight@google.com,iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28842

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -5 lines)			Patch
M	pkg/analyzer_experimental/lib/src/generated/ast.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/engine.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/intl/lib/extract_messages.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/intl/lib/src/intl_message.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r28842 (presubmit successful).

7 years, 2 months ago (2013-10-18 06:07:28 UTC) #2

Brian Wilkerson

We need to either (a) remove the use of lineInfo from clients, or (b) restore ...

7 years, 2 months ago (2013-10-18 13:48:28 UTC) #3

scheglov

On 2013/10/18 13:48:28, Brian Wilkerson wrote: > We need to either (a) remove the use ...

7 years, 2 months ago (2013-10-18 16:42:57 UTC) #4

Alan Knight

7 years, 2 months ago (2013-10-18 16:53:39 UTC) #5

Message was sent while issue was closed.

Um, lgtm, I guess. I believe the only reason I'm using lineInfo in Intl is to
provide an error message to the user when there's an invalid message. If there's
an alternative API to use I can change it.

Expand Messages | Collapse Messages