Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 281723004: Fix Directory, File and Link constructor text. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Directory, File and Link constructor text. A relative path is interpolated based on current working directory, not initial working directory. BUG=https://code.google.com/p/dart/issues/detail?id=17984 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=36154

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M sdk/lib/io/directory.dart View 1 1 chunk +7 lines, -3 lines 0 comments Download
M sdk/lib/io/file.dart View 1 1 chunk +7 lines, -1 line 0 comments Download
M sdk/lib/io/link.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-13 09:33:23 UTC) #1
Søren Gjesse
https://codereview.chromium.org/281723004/diff/1/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/281723004/diff/1/sdk/lib/io/directory.dart#newcode123 sdk/lib/io/directory.dart:123: * The path is either an absolute path, How ...
6 years, 7 months ago (2014-05-13 15:45:02 UTC) #2
Anders Johnsen
PTAL https://codereview.chromium.org/281723004/diff/1/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/281723004/diff/1/sdk/lib/io/directory.dart#newcode123 sdk/lib/io/directory.dart:123: * The path is either an absolute path, ...
6 years, 7 months ago (2014-05-14 08:51:10 UTC) #3
Søren Gjesse
lgtm
6 years, 7 months ago (2014-05-14 08:59:20 UTC) #4
Anders Johnsen
6 years, 7 months ago (2014-05-14 09:37:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r36154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698