Issue 281383004: Fix a bug when loading secondary assets in barback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281383004: Fix a bug when loading secondary assets in barback. (Closed)

Created:
6 years, 7 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a bug when loading secondary assets in barback. If a transformer group was followed by another transformer group, the second group would sometimes be unable to load secondary assets that were emitted by the first group. Also get barback ready to release 0.14.0+1. R=jmesserly@google.com BUG=18872 Committed: https://code.google.com/p/dart/source/detail?r=36391

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -18 lines)			Patch
M	pkg/barback/CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/group_runner.dart	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	pkg/barback/lib/src/graph/phase.dart	View	3 chunks	+13 lines, -10 lines	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/test/package_graph/group_test.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 7 months ago (2014-05-20 22:05:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36391 (presubmit successful).

Expand Messages | Collapse Messages