Issue 281373002: add RequestDatum tests and fix some situations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281373002: add RequestDatum tests and fix some situations (Closed)

Created:
6 years, 7 months ago by danrubel

Modified:
6 years, 7 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -30 lines)			Patch
	M	pkg/analysis_server/lib/src/protocol.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/protocol_test.dart	View	1	5 chunks	+49 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

danrubel

I commented out some of the test assertions to get the tests passing but at ...

6 years, 7 months ago (2014-05-14 21:50:47 UTC) #1

Paul Berry

lgtm Thank you for tracking this down. I don't know what I was thinking. Let ...

6 years, 7 months ago (2014-05-15 00:23:37 UTC) #2

danrubel

6 years, 7 months ago (2014-05-15 11:55:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36217 (presubmit successful).