Merge _idleConnections and _activeConnections into one structure, _ConnectionTarget.

Merge _idleConnections and _activeConnections into one structure, _ConnectionTarget.

The connection-target will at some point be in charge of handling
http client throttling.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36646

[Søren Gjesse, 2014-05-22 08:03:23]

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1508: final Set<_HttpClientConnection> idle = new
HashSet();
Rename idle and active to _idle and _active to indicate they are private. And
add methods to avoid direct access to these sets.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1521: void connectionClosed(_HttpClientConnection
connection) {
Add the assert from above here as well.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1741: bool hasActive =
_connectionTargets.values.any((t) => t.active.isNotEmpty);
Add hasActive (or hasActiveConnections) to ConnectionTarget to change

(t) => t.active.isNotEmpty

to

(t) => t.hasActiveConnections

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1743: bool hasIdle = _connectionTargets.values.any((t)
=> t.idle.isNotEmpty);
Add hasIdle (or hasIdleConnections) to ConnectionTarget.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1748: _connectionTargets.values.any((t) =>
t.active.isNotEmpty);
Ditto.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1776: if (connectionTarget != null &&
connectionTarget.idle.isNotEmpty) {
Add method getConnection to ConnectionTarget to avoid direct access to idle and
active members,

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1805: connectionTarget.active.add(tunnel);
Add method addConnection to ConnectionTarget

[Anders Johnsen, 2014-05-23 07:47:55]

PTAL

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1508: final Set<_HttpClientConnection> idle = new
HashSet();
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Rename idle and active to _idle and _active to indicate they are private. And
> add methods to avoid direct access to these sets.

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1521: void connectionClosed(_HttpClientConnection
connection) {
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Add the assert from above here as well.

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1741: bool hasActive =
_connectionTargets.values.any((t) => t.active.isNotEmpty);
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Add hasActive (or hasActiveConnections) to ConnectionTarget to change
> 
> (t) => t.active.isNotEmpty
> 
> to
> 
> (t) => t.hasActiveConnections

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1743: bool hasIdle = _connectionTargets.values.any((t)
=> t.idle.isNotEmpty);
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Add hasIdle (or hasIdleConnections) to ConnectionTarget.

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1748: _connectionTargets.values.any((t) =>
t.active.isNotEmpty);
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Ditto.

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1776: if (connectionTarget != null &&
connectionTarget.idle.isNotEmpty) {
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Add method getConnection to ConnectionTarget to avoid direct access to idle
and
> active members,

Done.

https://codereview.chromium.org/280813003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:1805: connectionTarget.active.add(tunnel);
On 2014/05/22 08:03:23, Søren Gjesse wrote:
> Add method addConnection to ConnectionTarget

Done.

[Søren Gjesse, 2014-05-23 09:49:10]

lgtm

https://codereview.chromium.org/280813003/diff/20001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/280813003/diff/20001/sdk/lib/io/http_impl.dar...
sdk/lib/io/http_impl.dart:1759: bool hasActive =
_connectionTargets.values.any((t) => t.hasActive);
We could consider abstracting the _connectionTargets into a ConnectionPool
class. But that can be a new change.

[Anders Johnsen, 2014-05-27 06:58:11]

Committed patchset #2 manually as r36646 (presubmit successful).