Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 28053005: Hide MirroredCompilationErrror behind a flag until post-1.0. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
gbracha, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe
Visibility:
Public.

Description

Hide MirroredCompilationErrror behind a flag until post-1.0. Remove VM reference to MirroredUncaughtExceptionError. R=asiva@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=28946

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -131 lines) Patch
M runtime/lib/mirrors.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 9 chunks +1 line, -66 lines 0 comments Download
A runtime/tests/vm/dart/mirrored_compilation_error_test.dart View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A + runtime/tests/vm/dart/redirection_type_shuffling_test.dart View 1 2 1 chunk +3 lines, -19 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/mirrors/redirection_type_shuffling_test.dart View 1 2 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-18 20:15:06 UTC) #1
gbracha
tests lgtm
7 years, 2 months ago (2013-10-18 20:26:19 UTC) #2
siva
https://codereview.chromium.org/28053005/diff/1/runtime/tests/vm/dart/isolate_mirror_local_test.dart File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right): https://codereview.chromium.org/28053005/diff/1/runtime/tests/vm/dart/isolate_mirror_local_test.dart#newcode484 runtime/tests/vm/dart/isolate_mirror_local_test.dart:484: void main() { Instead of removing all these tests ...
7 years, 2 months ago (2013-10-19 00:25:14 UTC) #3
rmacnak
https://codereview.chromium.org/28053005/diff/1/runtime/tests/vm/dart/isolate_mirror_local_test.dart File runtime/tests/vm/dart/isolate_mirror_local_test.dart (right): https://codereview.chromium.org/28053005/diff/1/runtime/tests/vm/dart/isolate_mirror_local_test.dart#newcode484 runtime/tests/vm/dart/isolate_mirror_local_test.dart:484: void main() { On 2013/10/19 00:25:14, siva wrote: > ...
7 years, 2 months ago (2013-10-21 18:26:08 UTC) #4
siva
lgtm
7 years, 2 months ago (2013-10-21 19:51:26 UTC) #5
rmacnak
7 years, 2 months ago (2013-10-21 20:12:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r28946 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698